On Thu, Oct 13, 2011 at 05:20:25PM +0100, Russell King - ARM Linux wrote:

On Thu, Oct 13, 2011 at 06:10:10PM +0200, Julien Boibessot wrote:

quoted

On 30/09/2011 15:35, Shawn Guo wrote:

quoted

It adds device tree support for imx51 babbage board.

cut

quoted

diff --git a/arch/arm/mach-mx5/imx51-dt.c b/arch/arm/mach-mx5/imx51-dt.c
new file mode 100644
index 0000000..0878441
--- /dev/null
+++ b/arch/arm/mach-mx5/imx51-dt.c

@@ -0,0 +1,116 @@

cut

quoted

+
+static void __init imx51_timer_init(void)
+{
+	mx51_clocks_init(32768, 24000000, 22579200, 0);
+}

From my understanding, if put in arch/arm/mach-mx5/imx51-dt.c, this
clock initialization will apply to all i.MX51 based platforms.
Am I right ?

In the general case, from the above code fragment, I'd say you are.
The timer init stuff is supposed to be for bringing up the timers.

Inside mx51_clocks_init(), after necessary clock setup, it will call
mxc_timer_init() to bring up the timer.  I agree with the suggestion
below, but I'm trying to reuse non-dt setup as much as possible with
minimum changes and impact to non-dt case.

Regards,
Shawn

We do have an early init callback which can be used for this - which
gets things like the clk stuff up and running from immediately after
the page tables have been setup and initial device mappings put in
place - before any drivers or even IRQ controllers have been
initialized.