Thread (2 messages) 2 messages, 2 authors, 2011-10-11
STALE5368d

[PATCH v6 05/16] OMAP2+: UART: Cleanup part of clock gating mechanism for uart

From: Kevin Hilman <hidden>
Date: 2011-10-10 22:30:43
Also in: linux-omap, linux-serial

"Govindraj.R" [off-list ref] writes:
Currently we use a shared irq handler to identify uart activity and then
trigger a timer. 
OK.
Based the timeout value set from sysfs the timer used to expire.
Please re-phrase as I'm not sure what is being said here.
If no uart-activity was detected timer-expiry func sets can_sleep
flag. Based on this we will disable the uart clocks in idle path.

Since the clock gating mechanism is outside the uart driver, we currently
use this mechanism. In preparation to runtime implementation for omap-serial
driver we can cleanup this mechanism and use runtime API's to gate uart clocks.

Also remove timer related info from local uart_state struct and remove
the code used to set timeout value from sysfs. Remove un-used function
omap_uart_check_wakeup.

Signed-off-by: Govindraj.R <redacted>
The patch itself fine, and is a well-neede cleanup, but changelog
(especially the first part) does not read well.

Kevin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help