Thread (9 messages) 9 messages, 3 authors, 2011-10-06
STALE5404d REVIEWED: 1 (0M)

[PATCH v2] ARM: OMAP3: PM: fix I/O wakeup and I/O chain clock control detection

From: sakoman@gmail.com (Steve Sakoman)
Date: 2011-10-06 21:22:23
Also in: linux-omap

On Thu, Oct 6, 2011 at 12:47 PM, Paul Walmsley [off-list ref] wrote:
The way that we detect which OMAP3 chips support I/O wakeup and
software I/O chain clock control is broken.

Currently, I/O wakeup is marked as present for all OMAP3 SoCs other
than the AM3505/3517. ?The TI81xx family of SoCs are at present
considered to be OMAP3 SoCs, but don't support I/O wakeup. ?To resolve
this, convert the existing blacklist approach to an explicit,
whitelist support, in which only SoCs which are known to support I/O
wakeup are listed. ?(At present, this only includes OMAP34xx,
OMAP3503, OMAP3515, OMAP3525, OMAP3530, and OMAP36xx.)

Also, the current code incorrectly detects the presence of a
software-controllable I/O chain clock on several chips that don't
support it. ?This results in writes to reserved bitfields, unnecessary
delays, and console messages on kernels running on those chips:

? ?http://www.spinics.net/lists/linux-omap/msg58735.html

Convert this test to a feature test with a chip-by-chip whitelist.

Thanks to Dave Hylands [off-list ref] for reporting this problem
and doing some testing to help isolate the cause. ?Thanks to Steve
Sakoman [off-list ref] for catching a bug in the first version of
this patch.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Kevin Hilman <redacted>
Cc: Dave Hylands <redacted>
Cc: Steve Sakoman <sakoman@gmail.com>
I just tested a Linux 3.0 version of the patch on both ES2.1
and ES3.1 and it works just fine.

So here is my:

Tested-by: Steve Sakoman <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help