Thread (18 messages) 18 messages, 5 authors, 2011-10-07
STALE5351d REVIEWED: 1 (0M)
Revisions (11)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 [diff vs current]
  4. v1 [diff vs current]
  5. v1 [diff vs current]
  6. v1 [diff vs current]
  7. v1 [diff vs current]
  8. v1 [diff vs current]
  9. v2 [diff vs current]
  10. v2 current
  11. v2 [diff vs current]

[PATCH 1/7] ARM: l2x0: add empty l2x0_of_init

From: Barry Song <hidden>
Date: 2011-09-01 03:36:20

2011/9/1 Rob Herring [off-list ref]:
From: Rob Herring <redacted>

Add empty version of l2x0_of_init for when CONFIG_CACHE_L2X0 is not selected.

Signed-off-by: Rob Herring <redacted>
Acked-by: Barry Song <redacted>

it seems most people use
"
#ifdef CONFIG_CACHE_L2X0
...
l2x0 related codes
...
#endif
"
or
"
obj-$(CONFIG_CACHE_L2X0) += xxx-l2x0.o
"

to avoid l2x0 related codes compiled and linked into kernel.

but this patch provides another option. it is not bad too.
quoted hunk ↗ jump to hunk
---
?arch/arm/include/asm/hardware/cache-l2x0.h | ? ?7 +++++++
?1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/arch/arm/include/asm/hardware/cache-l2x0.h b/arch/arm/include/asm/hardware/cache-l2x0.h
index 4a6004a..967a808 100644
--- a/arch/arm/include/asm/hardware/cache-l2x0.h
+++ b/arch/arm/include/asm/hardware/cache-l2x0.h
@@ -90,7 +90,14 @@
?#ifndef __ASSEMBLY__
?extern void __init l2x0_init(void __iomem *base, __u32 aux_val, __u32 aux_mask);
+#if defined(CONFIG_CACHE_L2X0) && defined(CONFIG_OF)
?extern int l2x0_of_init(__u32 aux_val, __u32 aux_mask);
+#else
+static int l2x0_of_init(__u32 aux_val, __u32 aux_mask)
+{
+ ? ? ? return -ENODEV;
+}
?#endif
+#endif /* __ASSEMBLY__ */

?#endif
--
1.7.4.1
-barry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help