[PATCH 1/5] ARM: pxa: remove redundant macro on GPIO
From: Eric Miao <hidden>
Date: 2011-09-30 02:43:23
From: Eric Miao <hidden>
Date: 2011-09-30 02:43:23
2011/9/30 Micha? Miros?aw [off-list ref]:
2011/9/29 Haojian Zhuang [off-list ref]: [...]quoted
? ? ? ?if (type & IRQ_TYPE_EDGE_RISING) - ? ? ? ? ? ? ? GRER0 |= GPIO_bit(gpio); + ? ? ? ? ? ? ? GRER(gpio) |= GPIO_bit(gpio);[...] This looks wrong. There are more occurrences like this. Can you explain if this is correct?
This is actually correct. In GRER(x) - x designates the GPIO instead of the subindex n in GRERn. The rest of the direct references GPxRn have been mostly removed during the last several rounds of cleanup. Haojian, Please use 'git grep GP.R[0-9]' and 'git grep GR.R[0-9]' to rule out the rest references. I'm good with the patch, just to make sure there is no more such reference.
Best Regards, Micha? Miros?aw