[PATCH v2 2/2] OMAP: omap_device: Add a method to build an omap_device from a DT node

"Cousson, Benoit" [off-list ref] writes:

On 9/17/2011 6:13 PM, Grant Likely wrote:

quoted

On Fri, Sep 16, 2011 at 04:43:19PM +0200, Benoit Cousson wrote:

[...]

quoted

quoted

+}
+
+static int _omap_device_notifier_call(struct notifier_block *nb,
+				      unsigned long event, void *dev)

Nit: Why the preceding underscore?  Generally that is only done for
'special' variants of public functions.  ie. for a variant that
expects a lock to already be held.

Yeah, the convention in this file is not that strict, and it is used
for internal static helper function as well.
I'll let Kevin arbitrate that point :-)

The convention in this file is the leading '_' is used for internal
helper functions.

I'd prefer to keep it that way, and if we decide to change the coding
convention to match a coding convention elsewhere, we should do it all
at the same time.

Kevin