On Wed, Sep 14, 2011 at 4:49 PM, Sergei Shtylyov [off-list ref] wrote:

Hello.

On 13-09-2011 17:02, Tarun Kanti DebBarma wrote:

quoted

Remove un-necessary bit masking. Since the register are 4 byte aligned
and readl would work as is. The 'enabled' mask is already taking care
to mask for bank width.

quoted

Signed-off-by: Charulatha V<redacted>
Signed-off-by: Tarun Kanti DebBarma<redacted>
Reviewed-by: Santosh Shilimkar<redacted>
---
?drivers/gpio/gpio-omap.c | ? ?2 --
?1 files changed, 0 insertions(+), 2 deletions(-)

quoted

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 876e387..d614c6d 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c

@@ -571,8 +571,6 @@ static void gpio_irq_handler(unsigned int irq, struct

irq_desc *desc)
? ? ? ? ? ? ? ?enabled = _get_gpio_irqbank_mask(bank);
? ? ? ? ? ? ? ?isr_saved = isr = __raw_readl(isr_reg)& ?enabled;

- ? ? ? ? ? ? ? if (cpu_is_omap15xx()&& ?(bank->method == METHOD_MPUIO))
- ? ? ? ? ? ? ? ? ? ? ? isr&= 0x0000ffff;

? Should have removed the now unneeded empty line too.

Sure... I will remove.
--
Tarun

quoted

? ? ? ? ? ? ? ?if (bank->level_mask)
? ? ? ? ? ? ? ? ? ? ? ?level_mask = bank->level_mask& ?enabled;

WBR, Sergei