Thomas Abraham wrote:

Dear Mr. Kim,

On 5 September 2011 10:47, Kukjin Kim [off-list ref] wrote:

quoted

quoted

Subject: [PATCH v2 6/6] ARM: EXYNOS4: Limit usage of pl330 device

instance

quoted

to

quoted

non-dt build

The pl330 device instances and associated platform data is required

only

quoted

quoted

for non-device-tree builds. With device tree, all of this information

is

quoted

quoted

obtained from the device tree.

Signed-off-by: Thomas Abraham <redacted>
---
?arch/arm/mach-exynos4/Kconfig ?| ? ?7 +++++++
?arch/arm/mach-exynos4/Makefile | ? ?3 ++-
?2 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-exynos4/Kconfig

b/arch/arm/mach-exynos4/Kconfig

quoted

quoted

index d4d401c..3edbf37 100644

--- a/arch/arm/mach-exynos4/Kconfig
+++ b/arch/arm/mach-exynos4/Kconfig

@@ -21,6 +21,13 @@ config EXYNOS4_MCT

? ? ? help
? ? ? ? Use MCT (Multi Core Timer) as kernel timers

+config EXYNOS4_DEV_DMA
+ ? ? bool
+ ? ? default y if !OF
+ ? ? help
+ ? ? ? Compile in amba device definitions for DMA controller if OF
+ ? ? ? is not enabled.
+
?config EXYNOS4_DEV_AHCI
? ? ? bool
? ? ? help

diff --git a/arch/arm/mach-exynos4/Makefile

b/arch/arm/mach-exynos4/Makefile

quoted

index d2bf5bf..a2f33dc 100644

--- a/arch/arm/mach-exynos4/Makefile
+++ b/arch/arm/mach-exynos4/Makefile

@@ -13,7 +13,8 @@ obj- ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?:=

?# Core support for EXYNOS4 system

?obj-$(CONFIG_CPU_EXYNOS4210) += cpu.o init.o clock.o irq-combiner.o
-obj-$(CONFIG_CPU_EXYNOS4210) += setup-i2c0.o irq-eint.o dma.o
pmu.o
+obj-$(CONFIG_CPU_EXYNOS4210) += setup-i2c0.o irq-eint.o pmu.o
+obj-$(CONFIG_EXYNOS4_DEV_DMA) ? ? ? ?+= dma.o

Do we need _really_ EXYNOS4_DEV_DMA here?
How about to use like following?

+obj-$(!CONFIG_OF) ? ? ? ? ? ? ?+= dma.o

If any problems, let me know.

While trying out your suggestion, I found a issue with this patch
related to compiling a kernel with both dt and non-dt board files
included in the build.

When compiling a single kernel image with mach-smdkv310.c file and
exynos4 device tree enabled machine file, since CONFIG_OF is enabled,
dma platform data does not get compiled which is required for
mach-smdkv310. So, I would like to resubmit this patch and the updated
diff is listed below. Could you please review the following diff.

Hi Thomas,

Oops, you're right...so following is ok to me but you need to rebase this
based on latest my tree.

If any problems, please let me know.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

b/arch/arm/mach-exynos4/Makefile