On Fri, Sep 16, 2011 at 10:34 PM, Rob Herring [off-list ref] wrote:

Dave,

On 09/16/2011 11:22 AM, Dave Martin wrote:

quoted

This patch enables device-tree-based probing of the pata-generic
platform driver across all architectures:

? * make the pata_of_generic module depend on OF instead of PPC_OF;
? * supply some missing inclues;
? * replace endianness-sensitive raw access to device tree data
? ? with of_property_read_u32() calls.

Signed-off-by: Dave Martin <redacted>
---
v2: correct sense of the check of_property_read_u32(dn, "pio-mode",
&pio_mode). ?Somehow I posted an old version of this patch, depite
having already fixed this...

Tested on ARM Versatile Express, with my soon-to-be-posted device
tree support patches.

I'm not in a position to build/test this for powerpc easily --
if anyone is able to do that, it would be appreciated.

Building just requires getting Codesourcery PPC toolchain...

True, but although I can try to build it, I don't have a PPC platform
to do the actual testing.

You also have to be aware that you are enabling this for all OF-enabled
arches which could break with an allyesconfig. So really you need sparc,
x86, mips, and microblaze, but a subset is probably sufficient.

Fair point.

Since this has now been superseded by Grant's patch anyway, I'll leave
it for others to judge.

Cheers
---Dave