Thread (2 messages) 2 messages, 2 authors, 2011-09-09

[PATCH REPOST 2/2] i2c-imx: add device tree probe support

From: Lothar Waßmann <hidden>
Date: 2011-09-09 11:10:59
Also in: linux-devicetree, linux-i2c

Hi,

Shawn Guo writes:
On Fri, Sep 09, 2011 at 09:18:45AM +0200, Uwe Kleine-K?nig wrote:
quoted
Hello Rob,

On Fri, Sep 09, 2011 at 12:14:22AM -0500, Rob Herring wrote:
quoted
quoted
+i2c at 83fc4000 { /* I2C2 on i.MX51 */
+	compatible = "fsl,imx51-i2c", "fsl,imx1-i2c";
+	reg = <0x83fc4000 0x4000>;
+	interrupts = <63>;
+};
+
+i2c at 70038000 { /* HS-I2C on i.MX51 */
The mainline driver doesn't support the HS-I2C block does it?

The high speed and "old" i2c blocks on MX51 are basically different
blocks, so the compatible property should be different.
I stumbled about that recently, too and found in
arch/arm/plat-mxc/devices/platform-imx-i2c.c that the third device
description for imx51 is a normal "imx-i2c" one using
MX51_HSI2C_DMA_BASE_ADDR. So I concluded it's different but compatible.

board-mx51_babbage.c uses imx51_add_hsi2c but doesn't add a bus
description. So It might not attract attention if the driver doesn't
match the device.
Aha, I was confused by the platform codes.  Will drop HSI2C.
According to the i.MX51 Ref. Manual it's so buggy that it should not even
be used:
|Chapter 39
|High Speed Inter IC (HS-I2C)
|39.1 Introduction
[...]
|                                   NOTE
|Due to limited functionality, Freescale does not recommend users
|incorporate the HS-I2C module in future designs. For details on the
|limitations, refer to the MX51 IC Errata. Users should consider using the
|two standard I2C modules, which have no errata.

Fortunately there is an i2c-gpio driver that can be used on the
corresponding pins. ;-)


Lothar Wa?mann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help