[PATCH v4 3/3] OMAP2+: voltage: add check for missing PMIC info in vp init
From: Kevin Hilman <hidden>
Date: 2011-09-22 21:39:27
Also in:
linux-omap, lkml
Abhilash K V [off-list ref] writes:
If PMIC info is not available in omap_vp_init(), abort. Signed-off-by: Abhilash K V <redacted>
Looks good, some minor nitpicking below...
quoted hunk
--- arch/arm/mach-omap2/vp.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)diff --git a/arch/arm/mach-omap2/vp.c b/arch/arm/mach-omap2/vp.c index 66bd700..2c99837 100644 --- a/arch/arm/mach-omap2/vp.c +++ b/arch/arm/mach-omap2/vp.c@@ -41,6 +41,13 @@ void __init omap_vp_init(struct voltagedomain *voltdm) u32 val, sys_clk_rate, timeout, waittime; u32 vddmin, vddmax, vstepmin, vstepmax; + if (!voltdm->pmic || !voltdm->pmic->uv_to_vsel) { + pr_err("%s: PMIC info requried to configure vp for"
nit 1: s/vp/VP/ nit 2: need a space at the end of this string, otherwise the "vdd_" will be right after the "for" with no spaces.
+ "vdd_%s not populated.Hence cannot initialize vp\n",
nit 3: Add space after '.' Kevin
+ __func__, voltdm->name);
+ return;
+ }
+
if (!voltdm->read || !voltdm->write) {
pr_err("%s: No read/write API for accessing vdd_%s regs\n",
__func__, voltdm->name);