Thread (4 messages) 4 messages, 4 authors, 2011-09-06
STALE5382d

[PATCH] dmaengine: amba-pl08x: make filter check that the channel is owned by pl08x

From: Michał Mirosław <hidden>
Date: 2011-08-31 08:47:44

2011/8/31 Russell King - ARM Linux [off-list ref]:
quoted hunk ↗ jump to hunk
Before converting the dma channel to our private data structure, first
check that the channel is indeed one which our driver registered. ?We
do this by ensuring that the underlying device is bound to our driver.

This avoids potential oopses if we try to reference 'plchan->name'
against a foreign drivers dma channel.

Signed-off-by: Russell King <redacted>
---
?drivers/dma/amba-pl08x.c | ? 10 +++++++++-
?1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index be21e3f..91d4148 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -92,6 +92,8 @@
?#define DRIVER_NAME ? ?"pl08xdmac"

+static struct amba_driver pl08x_amba_driver;
+
This will make C++ coders confused a bit. Valid C, though.

Best Regards,
Micha? Miros?aw
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help