On Tue, Jul 26, 2011 at 3:06 PM, Zhangfei Gao [off-list ref] wrote:

Move vmmc to set_ios, as a result mmc_power_up/down handles regulator_enable/disable vmmc
Move regulator outof spin_lock, since usually i2c operation is called
Remove vmmc from suspend/resume function, instead vmmc is handled properly in mmc_suspend/resume_host according to mmc_card_keep_power

CC: Ohad Ben-Cohen <redacted>
Signed-off-by: Zhangfei Gao <redacted>
---
?drivers/mmc/host/sdhci.c ?| ? 27 +++++++++++++++------------
?include/linux/mmc/sdhci.h | ? ?1 +
?2 files changed, 16 insertions(+), 12 deletions(-)

Hi, Daniel

We found some impact to sd if reusing vmmc in set_ios, when no sd card
is inserted.
When no sd card, CD pin is high, but when vmmc is disabled in
mmc_power_down, as a result CD pin will be pulled down, which is same
as sd card is inserted, however the card detect will fail since no sd
card in fact.

So additional regulator vsdio still required to control power of
vsdio, to make mmc_power_up/down control sdio power.

Thanks