[PATCH v9 2/3] MTD : add helper functions library and header files for GPMI NAND driver

On Monday, August 22, 2011 07:03:56 AM Huang Shijie wrote:

Hi,

quoted

On Wednesday, August 17, 2011 01:50:27 PM Huang Shijie wrote:

quoted

bch-regs.h : registers file for BCH module
gpmi-regs.h: registers file for GPMI module
gpmi-lib.c: helper functions library.

Signed-off-by: Huang Shijie<redacted>
---

[...]

quoted

quoted

+err_out:
+	return ret;
+}
+
+/* This is very useful! */

Really? Cool, what for ?
btw. this should really be enclosed in some #ifdef debug or whatnot.

Yes, it shows the register contents when DMA timeout occurs.
this routine is called only when error occurs.

Hi,

I'd expect exactly this explanation to be in the comment ;-)

Cheers