Thread (25 messages) 25 messages, 3 authors, 2011-08-28

[PATCHv3 4/9] macb: convert printk to netdev_ and friends

flat view
STALE5532d

From: joe@perches.com (Joe Perches)
Date: 2011-08-09 20:20:27
Also in: netdev

On Tue, 2011-08-09 at 10:16 +0100, Jamie Iles wrote:
macb is already using the dev_dbg() and friends helpers so use netdev_()
along with a pr_fmt() definition to make the printing a little cleaner.
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/macb.c b/drivers/net/macb.c
[]
quoted hunk ↗ jump to hunk
@@ -8,6 +8,7 @@
[]
+#define pr_fmt(fmt) "macb: " fmt
Hi Jamie.

Just trivia.

Please use #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 
instead.  There would be no output difference.

That'll make it easier to remove later when all of
of these #defines pr_fmt that use just KBUILD_MODNAME
can be removed.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help