Thread (12 messages) flat view 12 messages, 3 authors, 2011-10-24
STALE5397d

[PATCH] gpio: pl061: add DT binding support

From: baruch@tkos.co.il (Baruch Siach)
Date: 2011-08-03 19:10:46

Hi Rob,

On Wed, Aug 03, 2011 at 01:54:21PM -0500, Rob Herring wrote:
From: Rob Herring <redacted>

This adds devicetree binding support to the ARM pl061 driver removing the
platform_data dependency. When DT binding is used, the gpio numbering is
assigned dynamically. The interrupt assignment is converted to use the
irq_domain infrastructure.

Signed-off-by: Rob Herring <redacted>
Cc: Grant Likely <redacted>
---
 drivers/gpio/gpio-pl061.c |   32 +++++++++++++++++++++++---------
 1 files changed, 23 insertions(+), 9 deletions(-)
[snip]
quoted hunk ↗ jump to hunk
@@ -283,7 +295,7 @@ static int pl061_probe(struct amba_device *dev, const 
struct amba_id *id)
 	 * irq_chip support
 	 */
 
-	if (chip->irq_base == (unsigned) -1)
+	if (chip->irq_base == NO_IRQ)
Please update the comment at include/linux/amba/pl061.h as well.
quoted hunk ↗ jump to hunk
 		return 0;
 
 	writeb(0, chip->base + GPIOIE); /* disable irqs */
@@ -307,11 +319,13 @@ static int pl061_probe(struct amba_device *dev, const struct amba_id *id)
[snip]

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help