On Tue, Aug 23, 2011 at 01:53:54PM +0530, Rajendra Nayak wrote:

On 8/23/2011 10:33 AM, G, Manjunath Kondaiah wrote:

quoted

Add omap4 soc dts file for handling omap4 soc i2c
controllers existing on l4-core bus.

Signed-off-by: G, Manjunath Kondaiah<redacted>
---
 arch/arm/boot/dts/omap4-panda.dts |    7 +---
 arch/arm/boot/dts/omap4.dtsi      |   68 +++++++++++++++++++++++++++++++++++++
 2 files changed, 69 insertions(+), 6 deletions(-)
 create mode 100644 arch/arm/boot/dts/omap4.dtsi

diff --git a/arch/arm/boot/dts/omap4-panda.dts b/arch/arm/boot/dts/omap4-panda.dts
index 58909e9..c28aa95 100644
--- a/arch/arm/boot/dts/omap4-panda.dts
+++ b/arch/arm/boot/dts/omap4-panda.dts

@@ -1,9 +1,4 @@
-/dts-v1/;
-
-/memreserve/ 0x9D000000 0x03000000; /* Frame buffer */
-/memreserve/ 0xB0000000 0x10000000; /* Top 256MB is unaccessable */
-
-/include/ "skeleton.dtsi"
+/include/ "omap4.dtsi"

 / {
 	model = "TI OMAP4 PandaBoard";

diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
new file mode 100644
index 0000000..cb055f5
--- /dev/null
+++ b/arch/arm/boot/dts/omap4.dtsi

@@ -0,0 +1,68 @@
+/*
+ * Device Tree Source for OMAP4 SoC
+ *
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This file is licensed under the terms of the GNU General Public License
+ * version 2.  This program is licensed "as is" without any warranty of any
+ * kind, whether express or implied.
+ */
+
+/dts-v1/;
+
+/memreserve/ 0x9D000000 0x03000000; /* Frame buffer */
+/memreserve/ 0xB0000000 0x10000000; /* Top 256MB is unaccessable */
+
+/include/ "skeleton.dtsi"
+
+/ {
+	#address-cells =<1>;
+	#size-cells =<1>;
+	model = "ti,omap4";
+
+	aliases {
+		i2c1 =&i2c1;
+		i2c2 =&i2c2;
+		i2c3 =&i2c3;
+		i2c4 =&i2c4;
+	};
+
+	l4-core {
+		compatible = "ti,omap4-l4-core", "sonics,s3220";
+		#address-cells =<1>;
+		#size-cells =<1>;
+		ranges =<0 0x48000000 0x1000000>;
+
+		i2c1: i2c at 70000 {
+			#address-cells =<1>;
+			#size-cells =<0>;

Are these really needed, given there are no child nodes defined?
Same with all other instances.

This will define all the available resources for a given soc and it
can be disabled by using "status=disabled" in property field.

This is ongoing debate whether to have status field or not. 

Grant,
What is the final alignment on using status field?

-M

quoted

+			compatible = "ti,omap-i2c", "ti,omap-device";
+			reg =<0x70000 0x100>;
+			interrupts =<  88>;
+		};
+
+		i2c2: i2c at 72000 {
+			#address-cells =<1>;
+			#size-cells =<0>;
+			compatible = "ti,omap-i2c", "ti,omap-device";
+			reg =<0x72000 0x100>;
+			interrupts =<  89>;
+		};
+
+		i2c3: i2c at 60000 {
+			#address-cells =<1>;
+			#size-cells =<0>;
+			compatible = "ti,omap-i2c", "ti,omap-device";
+			reg =<0x60000 0x100>;
+			interrupts =<  93>;
+		};
+
+		i2c4: i2c at 350000 {
+			#address-cells =<1>;
+			#size-cells =<0>;
+			compatible = "ti,omap-i2c", "ti,omap-device";
+			reg =<0x350000 0x100>;
+			interrupts =<  94>;
+		};
+	};
+};