[PATCH 2/2] omap_twl: Prevent SR to enable for am3517/am3505 devices

"Koyamangalath, Abhilash" [off-list ref] writes:

Kevin Hilman wrote:

quoted

Abhilash K V [off-list ref] writes:

quoted

From: Vaibhav Hiremath <redacted>

In case of AM3517 & AM3505, Smart Reflex is not applicable so
we must not enable it. So add check for am3517/05 cpu revision
in omap3_twl_init() and return -ENODEV if true, else continue.

Signed-off-by: Vaibhav Hiremath <redacted>
Signed-off-by: Abhilash K V <redacted>
---
 arch/arm/mach-omap2/omap_twl.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_twl.c

b/arch/arm/mach-omap2/omap_twl.c

quoted

index 07d6140..92fadcb 100644

--- a/arch/arm/mach-omap2/omap_twl.c
+++ b/arch/arm/mach-omap2/omap_twl.c

@@ -269,6 +269,14 @@ int __init omap3_twl_init(void)
       if (!cpu_is_omap34xx())
               return -ENODEV;

+     /*
+      * In case of AM3517/AM3505 we should not be going down
+      * further, since SR is not applicable there.
+      */
+     if (cpu_is_omap3505() || cpu_is_omap3517()) {
+             return -ENODEV;
+     }
+

Rather than using cpu_is_*, you should add a new "feature" flag for
SmartReflex.  We already have this for things like SGX, IVA, NEON, etc.
See <plat/feature.h>

I did not find a feature.h; 

sorry, I meant <plat/cpu.yh>

did you mean OMAP3_CHECK_FEATURE macro which is used by
omap3_check_features(), which gleans for presence of L2CACHE, IVA, SGX, NEON, ISP features
from the Control Device Status Register (0x4800 244C) ?

yes, OMAP3_HAS_FEATURE()

There is no such bit-field to indicate the presence of smart-reflex feature in this register.
AFAIK, there is no such global register as well which could indicate this.

There doesn't have to be a register read to indicate this.  See for
example the HAS_IO_WAKEUP feature.

Kevin

- Abhilash

quoted

Kevin

quoted

       if (cpu_is_omap3630()) {
               omap3_mpu_volt_info.vp_vddmin =

OMAP3630_VP1_VLIMITTO_VDDMIN;

quoted

               omap3_mpu_volt_info.vp_vddmax =

OMAP3630_VP1_VLIMITTO_VDDMAX;