Thread (22 messages) 22 messages, 6 authors, 2011-08-18

[PATCH] ARM: zImage: Skip relinking if nothing changes

From: nico@fluxnic.net (Nicolas Pitre)
Date: 2011-08-18 03:44:07
Also in: linux-kbuild, lkml

On Fri, 12 Aug 2011, Arnaud Lacombe wrote:
On Fri, Aug 12, 2011 at 4:48 PM, Arnaud Lacombe [off-list ref] wrote:
quoted
On Fri, Aug 12, 2011 at 3:00 PM, Stephen Boyd [off-list ref] wrote:
quoted
diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
index 0c74a6f..937fd26 100644
--- a/arch/arm/boot/compressed/Makefile
+++ b/arch/arm/boot/compressed/Makefile
@@ -91,7 +91,7 @@ suffix_$(CONFIG_KERNEL_LZMA) = lzma
?targets ? ? ? := vmlinux vmlinux.lds \
? ? ? ? ? ? ? ? piggy.$(suffix_y) piggy.$(suffix_y).o \
- ? ? ? ? ? ? ? ?font.o font.c head.o misc.o $(OBJS)
+ ? ? ? ? ? ? ? ?font.o font.c head.o misc.o lib1funcs.o lib1funcs.S $(OBJS)

?# Make sure files are removed during clean
?extra-y ? ? ? += piggy.gzip piggy.lzo piggy.lzma lib1funcs.S
@@ -121,9 +121,7 @@ LDFLAGS_vmlinux += -X
?LDFLAGS_vmlinux += -T

?# For __aeabi_uidivmod
-lib1funcs = $(obj)/lib1funcs.o
-
-$(obj)/lib1funcs.S: $(srctree)/arch/$(SRCARCH)/lib/lib1funcs.S FORCE
+$(obj)/lib1funcs.S: $(srctree)/arch/$(SRCARCH)/lib/lib1funcs.S
? ? ? ?$(call cmd,shipped)
You should be able to avoid the extra copy altogether by doing something ala:

$(obj)/lib1funcs.o: $(srctree)/arch/arm/lib/lib1funcs.S
? ? ? ?$(call cmd,as_o_S)

note that I also remove the $(SRCARCH), as there is no other
`arch/*/lib/lib1funcs.S' than `arch/arm/lib/lib1funcs.S'
I withdraw this proposal and will hack around this to find a proper
solution from within kbuild, and eventually come back on these uses
:-)
Any progress on this?

I have a patch doing multiple similar $(call cmd,shipped) at the moment 
and this is far from looking nice.


Nicolas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help