On 08/04/2011 02:22 PM, Koul, Vinod wrote:

i dont think pm_runtime_put_sync() is the right thing to do here. This
will call your suspend and return after suspend has been called. This
will delay your probe completion and have impact on system boot time,
this is a very wrong approach.
Please move this to _put, so that suspend will be called asynchronously

Also while at it why should you require all the _put calls to be _sync
type?

That was a mistake, and i already fixed this in a reply to Russell's mail
today.

-- 
viresh