Thread (3 messages) 3 messages, 3 authors, 2011-08-01
STALE5450d REVIEWED: 1 (0M)

[PATCH v2] OMAP: ctrl: Fix CONTROL_DSIPHY register fields

From: Santosh Shilimkar <hidden>
Date: 2011-07-27 10:27:07
Also in: linux-omap

On 7/27/2011 4:03 PM, Archit Taneja wrote:
Fix the shift and mask macros for DSIx_PPID fields in CONTROL_DSIPHY. The
OMAP4430 Public TRM vV has these fields mentioned correctly.

Signed-off-by: Archit Taneja<redacted>
Acked-by: Benoit Cousson<redacted>
---
v2:
- Improve commit description.
- Define fields in decreasing order of the field's end bit.
Thanks for the update.
Acked-by: Santosh Shilimkar <redacted>
quoted hunk ↗ jump to hunk
  .../include/mach/ctrl_module_pad_core_44xx.h       |    8 ++++----
  1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
index c88420d..1e2d332 100644
--- a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
+++ b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
@@ -941,10 +941,10 @@
  #define OMAP4_DSI2_LANEENABLE_MASK				(0x7<<  29)
  #define OMAP4_DSI1_LANEENABLE_SHIFT				24
  #define OMAP4_DSI1_LANEENABLE_MASK				(0x1f<<  24)
-#define OMAP4_DSI1_PIPD_SHIFT					19
-#define OMAP4_DSI1_PIPD_MASK					(0x1f<<  19)
-#define OMAP4_DSI2_PIPD_SHIFT					14
-#define OMAP4_DSI2_PIPD_MASK					(0x1f<<  14)
+#define OMAP4_DSI2_PIPD_SHIFT					19
+#define OMAP4_DSI2_PIPD_MASK					(0x1f<<  19)
+#define OMAP4_DSI1_PIPD_SHIFT					14
+#define OMAP4_DSI1_PIPD_MASK					(0x1f<<  14)

  /* CONTROL_MCBSPLP */
  #define OMAP4_ALBCTRLRX_FSX_SHIFT				31
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help