Russell King - ARM Linux Wrote:

Sent: Monday, July 25, 2011 6:40 PM
To: Boojin Kim
Cc: linux-arm-kernel at lists.infradead.org;

linux-samsung-soc at vger.kernel.org;

Kukjin Kim; Vinod Koul; Jassi Brar; Grant Likely; Mark Brown; Dan Williams
Subject: Re: [PATCH V4 12/14] spi/s3c64xx: Add support DMA engine API

On Mon, Jul 25, 2011 at 10:28:30AM +0900, Boojin Kim wrote:

quoted

+static void s3c64xx_spi_dma_rxcb(void *data)
+{
+	struct s3c64xx_spi_driver_data *sdd
+		= (struct s3c64xx_spi_driver_data *)data;

You never need explicit casts from void * or to void *.  Please remove
these.

I will address your comment.