Thread (25 messages) 25 messages, 4 authors, 2011-07-15
STALE5457d

[PATCH] ARM: OMAP4: PCM049: remove vusim regulator

From: tony@atomide.com (Tony Lindgren)
Date: 2011-07-15 08:20:12
Also in: linux-omap

* Felipe Balbi [off-list ref] [110715 00:53]:
Hi,

On Fri, Jul 15, 2011 at 12:50:24AM -0700, Tony Lindgren wrote:
quoted
* Jan Weitzel [off-list ref] [110714 01:34]:
quoted
Am Donnerstag, den 14.07.2011, 00:34 -0700 schrieb Tony Lindgren:
quoted
* Jan Weitzel [off-list ref] [110713 05:51]:
quoted
Am Mittwoch, den 13.07.2011, 16:13 +0400 schrieb Sergei Shtylyov:
quoted
    Have you added that 'i' at the end intentionally?
Thank you. It was a tribute to vim.
:i)

I'll fold the fixed patch into your original patch. Will also
keep the new board files in testing-board because of the code
coalescing and device tree conversion effort.
So there is no way to get the board mainline yet?
Well we can add it even before device tree support if it makes
sense from code coalescing point of view. In this case it would
mean creating board-panda-common.c or similar so the code can
be shared amongst the panda variants.

It seems that some GPIO pins are different and there are some
difference in devices connected, but big parts of the code can be
shared.
isn't it easier than to just add a few if (machine_is_xxxx()) checks and
another MACHINE_START() to board-omap4panda.c rather than creating a new
file, shuffling code around and then adding a new board file ??
That works too if the init_machine does not get too complicated.

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help