Thread (8 messages) 8 messages, 3 authors, 2011-07-10
STALE5444d
Revisions (6)
  1. v3 [diff vs current]
  2. v3 current
  3. v4 [diff vs current]
  4. v5 [diff vs current]
  5. v6 [diff vs current]
  6. v6 [diff vs current]

[PATCH 3/3] mc13xxx: implicitly enable leds and buttons

From: Uwe Kleine-König <hidden>
Date: 2011-07-10 08:04:50
Also in: linux-input

Hello,

On Sun, Jul 10, 2011 at 01:06:36AM +0200, Philippe R?tornaz wrote:
The leds and buttons subdevices cannot be used without additional
platform data.

Use the presence of the platform data to enable the device instead
of an additional flag.
I guess you could make some people happy by splitting this patch into:

	- mfd/mc13xxx: implicitly enable leds and buttons (and
	  regulators?)
	- drop MC13XXX_USE_... in arch code

because the patches have different paths into mainline (unless it's
handled otherwise).

And I wonder why you introduce MC13XXX_USE_BUTTON in the first place.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help