Thread (3 messages) flat view 3 messages, 2 authors, 2011-07-01

[PATCH] DMA: OMAP: Remove extra looping from omap_request_dma

From: tony@atomide.com (Tony Lindgren)
Date: 2011-07-01 07:19:46
Also in: linux-omap, lkml

* Scott Ellis [off-list ref] [110629 20:58]:
Break from dma channel search when a free one is found.
Care to describe how the current code is not finding a
free channel currently?

Tony

 
quoted hunk ↗ jump to hunk
Signed-off-by: Scott Ellis <redacted>
---
 arch/arm/plat-omap/dma.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index c22217c..3d36fcf 100644
--- a/arch/arm/plat-omap/dma.c
+++ b/arch/arm/plat-omap/dma.c
@@ -678,10 +678,9 @@ int omap_request_dma(int dev_id, const char *dev_name,
 
 	spin_lock_irqsave(&dma_chan_lock, flags);
 	for (ch = 0; ch < dma_chan_count; ch++) {
-		if (free_ch == -1 && dma_chan[ch].dev_id == -1) {
+		if (dma_chan[ch].dev_id == -1) {
 			free_ch = ch;
-			if (dev_id == 0)
-				break;
+			break;
 		}
 	}
 	if (free_ch == -1) {
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help