Thread (29 messages) 29 messages, 8 authors, 2011-07-13
STALE5434d

[PATCH v7 1/3] MTD : add the common code for GPMI-NFC controller driver

From: Wolfram Sang <hidden>
Date: 2011-06-29 12:49:02

On Wed, Jun 29, 2011 at 01:42:14PM +0100, Russell King - ARM Linux wrote:
On Wed, Jun 29, 2011 at 02:29:42PM +0200, Wolfram Sang wrote:
quoted
quoted
quoted
Still, the problem exists: When a second channel GPMI channel is
requested, dmaengine will return -EBUSY, because the DMAIRQ is already
taken.
Yes, we should change the DMA code, it is a DMA bug.
I ever submitted a patch about the issue:
http://patchwork.ozlabs.org/patch/87145/
That approach was rejected because it would register the same handler
n-times where one time would do. Your other approach puts too much
mach-specific details into the driver IMO and probably won't scale very
well. Maybe we should add something to the private dma_data (like flags
indicating SHARED) and then do some refcounting?
Why not just request the interrupt once when the mxs-dma stuff probes,
rather than requesting it every time a channel is allocated?
It is only the NAND DMA channels which share one dma-irq. All other
channels have a seperate interrupt.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110629/4ebf5f45/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help