[PATCH V3 0/9] pxa3xx_nand: add two chip select support
From: dedekind1@gmail.com (Artem Bityutskiy)
Date: 2011-06-29 10:20:00
On Wed, 2011-06-29 at 12:00 +0300, Igor Grinberg wrote:
Hi Lei, On 06/29/11 06:51, Lei Wen wrote:quoted
V2: Choose to at most keep original pxa3xx_nand_info structure to reduce patch size V3: Seperate original one patch into a patch set Lei Wen (9): MTD: pxa3xx_nand: convert all printk into dev_* MTD: pxa3xx_nand: enable multiple chip select support ARM: aspenite: fix nand platform data ARM: cm-x300: fix nand platform data ARM: colibri-pxa3xx: fix nand platform data ARM: littleton: fix nand platform data ARM: mxm8x10: fix nand platform data ARM: raumfeld: fix nand platform data ARM: zylonite: fix nand platform dataWhile I agree with Artem, that reviewing patch sets are much more easier, than a one single big patch, I think you should keep the "fix nand platform data" changes all in one patch. All of them do the same change, but for different boards.
Yeah, I did not suggest to split a large patch to a number of micro-patches plus another large patch :-) My suggestion is to have a set of easily reviewable patches. If you do the same thing in many platform data structures, it is reviewable and can be in one patch. -- Best Regards, Artem Bityutskiy