Hi Felipe,

On 27 June 2011 14:05, Felipe Balbi [off-list ref] wrote:

quoted

quoted

quoted

quoted

+static struct regulator_consumer_supply sdp4430_vusb_supply =
+ ? ? ? REGULATOR_SUPPLY("hsusb0", "ehci-omap.0");

this should be an array.

Ok, I can make it an array of _one_ element.
Though I am not sure why is that a good thing, or are we to use another
possible VUSB supply on Panda/SDP boards ? ?Please suggest so that
I can add that too.

same comment I gave before to another patch:

it makes the diff a lot easier to understand should anyone modify this
later. It's also a matter of consistency.

A quick grep showed otherwise though ...

In arch/arm/mach-omap2/
Total regulators defined                          =  71
Regulators with exactly 1 supply           =   58
Single element non-array definitions     =  46/58
Single element array definitions             =  12/58

Even if we consider 20% to be norm for consistency, I am not sure it's
a good one.

Still many samsung guys piously enclose magic value defines in parenthesis,
just to maintain 'consistency' !

And, I don't understand how does diff become any easier beyond 2
elements in the array.

Sorry for being bitchy, but I am unable to buy any reason other than
having more than
one element to use array.

-Jassi

-- 
Linaro.org ? Open source software for ARM SoCs | Follow Linaro
http://facebook.com/pages/Linaro/155974581091106 ?-
http://twitter.com/#!/linaroorg - http://linaro.org/linaro-blog