[RFC][PATCH 2/5] ARM: SAMSUNG: Changing the build condition of OTG platform device for samsung.
From: Felipe Balbi <hidden>
Date: 2011-06-21 11:49:41
Also in:
linux-samsung-soc
Hi, On Tue, Jun 21, 2011 at 03:47:04PM +0400, Sergei Shtylyov wrote:
Hello. On 21-06-2011 11:03, p.paneri at samsung.com wrote:quoted
From: Praveen Paneri<redacted>quoted
Adding dwc driver name in existing platform device to probe DWC OTG driver. Introduced otg_set_platdata function to pass platform data Added selectable config option to add DWC OTG driver for different machines.quoted
Signed-off-by: Praveen Paneri<redacted>[...]quoted
diff --git a/arch/arm/plat-samsung/dev-usb-hsotg.c b/arch/arm/plat-samsung/dev-usb-hsotg.c index 33a844a..7e6228b 100644 --- a/arch/arm/plat-samsung/dev-usb-hsotg.c +++ b/arch/arm/plat-samsung/dev-usb-hsotg.c[...]quoted
@@ -37,7 +39,12 @@ static struct resource s3c_usb_hsotg_resources[] = { static u64 s3c_hsotg_dmamask = DMA_BIT_MASK(32); struct platform_device s3c_device_usb_hsotg = { +#ifdef CONFIG_S3C_DEV_USB_HSOTG .name = "s3c-hsotg", +#endif +#ifdef CONFIG_S3C_DEV_DWC_OTG + .name = "dwc_otg", +#endifI'd done it as: +#if defined(CONFIG_S3C_DEV_USB_HSOTG) .name = "s3c-hsotg", +#elif defined(CONFIG_S3C_DEV_DWC_OTG) + .name = "dwc_otg", +#endif
no... don't do that. How many times do I have to repeat ? No ifdefs!! we want both drivers to be able to be compiled as modules, so add both platform devices. -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 490 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110621/fdefed2c/attachment.sig>