Thread (4 messages) flat view 4 messages, 3 authors, 2011-06-17
DORMANTno replies

[PATCH] collie: don't read GPSR

From: Dmitry Eremin-Solenikov <hidden>
Date: 2011-06-17 15:35:59

On 6/17/11, Eric Miao [off-list ref] wrote:
Would it be better to switch to use gpio_* API instead of manipulating
GPxR directly?
Yes. Probably. But this would require a much bigger cleanup effort. Waiting
for spare time for it.
On Fri, Jun 17, 2011 at 10:11 PM, Dmitry Eremin-Solenikov
[off-list ref] wrote:
quoted
On StrongARM GPSR is write-only according to docs, so don't read from
it. Just set the required GPIO.

Signed-off-by: Dmitry Eremin-Solenikov <redacted>
---
 arch/arm/mach-sa1100/collie.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-sa1100/collie.c b/arch/arm/mach-sa1100/collie.c
index f28025e..3f32ba2 100644
--- a/arch/arm/mach-sa1100/collie.c
+++ b/arch/arm/mach-sa1100/collie.c
@@ -339,7 +339,7 @@ static void __init collie_init(void)

       PCFR = PCFR_OPDE;

-       GPSR |= _COLLIE_GPIO_UCB1x00_RESET;
+       GPSR = _COLLIE_GPIO_UCB1x00_RESET;


       platform_scoop_config = &collie_pcmcia_config;
--
1.7.5.3

-- 
With best wishes
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help