[PATCH] mach-ixp4xx: fix build error

On Wed, Jun 15, 2011 at 3:29 PM, Richard Cochran
[off-list ref] wrote:

On Wed, Jun 15, 2011 at 10:43:10AM +0200, Linus Walleij wrote:

quoted

From: Linus Walleij <redacted>

The introduction of clocksource_mmio_init() broke ixp4xx due to
a surplus ampersand - IXP4XX_OSTS is already a pointe to I/O
space.

The fix you suggest will not work on big endian ixp. See

Yeah! I see. Sorry for missing it, I was just looking over the broken
kisskb items.

? http://lists.arm.linux.org.uk/lurker/message/20110530.084307.f960f906.en.html

You do this:

+static cycle_t ixp4xx_clocksource_read(struct clocksource *c)
+{
+    return *IXP4XX_OSTS;
+}

Which is essentially __raw_readl(IXP4XX_OSTS) to get the timer in current
endianness, is it not? So please use __raw_readl() for that if I'm right.

Thanks,
Linus Walleij