Thread (3 messages) 3 messages, 3 authors, 2011-06-10
DORMANTno replies

[PATCH 2/2] amba pl011: platform data for reg lockup and glitch

From: Shreshtha Kumar SAHU <hidden>
Date: 2011-06-10 09:07:06
Also in: linux-serial

On Thu, Jun 09, 2011 at 23:02:18 +0200, Russell King - ARM Linux wrote:
On Thu, Jun 09, 2011 at 10:56:48PM +0200, Linus Walleij wrote:
quoted
+	/* uart-0 pins gpio configuration should be
+	 * kept intact to prevent glitch in tx line
+	 * when tty dev is opened. Later these pins
+	 * are configured to uart mop500_pins_uart0
+	 *
+	 * It will be replaced with uart configuration
+	 * once the issue is solved.
+	 */
+	GPIO0_GPIO	| PIN_INPUT_PULLUP,
+	GPIO1_GPIO	| PIN_OUTPUT_HIGH,
+	GPIO2_GPIO	| PIN_INPUT_PULLUP,
+	GPIO3_GPIO	| PIN_OUTPUT_LOW,
Why do you want the TXD line (GPIO3) to be indicating a break condition?
Yes it should be PIN_OUTPUT_HIGH, as it is configured in mop500_pins_uart0.

Thanks,
Shreshtha
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help