[PATCH v4 3/4] drivers/amba: create devices from device tree

On Friday 10 June 2011 22:48:42 Rob Herring wrote:

+#ifdef CONFIG_OF
+int of_amba_device_create(struct device_node *node, struct device *parent);
+#endif
+
+#else
+
+#ifdef CONFIG_OF
+static inline int of_amba_device_create(struct device_node *node, 
+                                       struct device *parent)
+{
+       return 0;
+}
+#endif
+

We normally don't use #ifdef around declarations like this, it doesn't
hurt to have them even when the code is not there. Otherwise the patch
looks good.

	Arnd