On 30 June 2011 12:34, Russell King - ARM Linux [off-list ref] wrote:

On Fri, Jun 24, 2011 at 08:38:44PM +0200, Vincent Guittot wrote:

quoted

+ ? ? printk(KERN_INFO "cpu %u : thread %d cpu %d, socket %d, mpidr %x\n",
+ ? ? ? ? ? ? cpuid, cpu_topology[cpuid].thread_id,
+ ? ? ? ? ? ? cpu_topology[cpuid].core_id,
+ ? ? ? ? ? ? cpu_topology[cpuid].socket_id, mpidr);
+
+}

Please remove that empty blank line before the closing brace.

ok

Also...

cpu 0 : thread -1 cpu 0, socket 0, mpidr 80000000
Calibrating local timer... 199.99MHz.
hw perfevents: enabled with ARMv7 Cortex-A9 PMU driver, 7 counters available
CPU1: Booted secondary processor
cpu 1 : thread -1 cpu 1, socket 0, mpidr 80000001
CPU2: Booted secondary processor
cpu 2 : thread -1 cpu 2, socket 0, mpidr 80000002
CPU3: Booted secondary processor
cpu 3 : thread -1 cpu 3, socket 0, mpidr 80000003
Brought up 4 CPUs

It'd be better to have some consistency there - please change from
"cpu %u :" to "CPU%u:".

ok