On Wed, Jun 29, 2011 at 10:42 PM, Kukjin Kim [off-list ref] wrote:

MyungJoo Ham wrote:

quoted

In S5PV210/S5PC110/Exynos4, ADCMUX channel selection uses ADCMUX
register, not ADCCON register. This patch corrects the behavior of
Samsung-ADC for such cpus.

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
--
v2: No changes from v1. Resubmitted as a series of patches
---

[]

quoted

?enum s3c_cpu_type {
? ? ? TYPE_S3C24XX,
- ? ? TYPE_S3C64XX
+ ? ? TYPE_S3C64XX,
+ ? ? TYPE_S5P,
?};

How about S5PC100? Following is better for next if we cannot distinguish it
by CPU.

-enum s3c_cpu_type {
- ? ? ? TYPE_S3C24XX,
- ? ? ? TYPE_S3C64XX
+enum samsung_adc_type {
+ ? ? ? TYPE_ADC24, ? ? ?/* S3C24XX */
+ ? ? ? TYPE_ADC64, ? ? ?/* S3C64XX, S5P64X0, S5PC100 */
+ ? ? ? TYPE_ADCV3 ? ? ?/* S5PV210, EXYNOS4210 */
?};
...

TYPE_ADCV1 and V2?...
Of course, the name can be changed...

I don't mind about these names as they are just internal values of adc.c.
Anyway, I prefer the last suggestion and I'll use TYPE_ADCV1/V2/V3.

Thanks.

-- 
MyungJoo Ham (???), Ph.D.
Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: 82-10-6714-2858