Thread (10 messages) flat view 10 messages, 3 authors, 2011-06-29

[PATCH 2/4] ARM: remove unnecessary mach/hardware.h includes

From: Rob Herring <hidden>
Date: 2011-06-29 02:41:37
Also in: lkml

On 06/28/2011 06:24 PM, Russell King - ARM Linux wrote:
On Tue, Jun 28, 2011 at 05:57:37PM -0500, Rob Herring wrote:
quoted
From: Rob Herring <redacted>

Remove some includes of mach/hardware.h which are not needed. hardware.h will
be removed completely for tegra and cns3xxx in follow on patch.
At least this one is incorrect:

arch/arm/mach-rpc/include/mach/hardware.h:#define IO_EC_MEMC_BASE              0x80000000
arch/arm/kernel/ecard.c:                    address = IO_EC_MEMC_BASE + (slot << 12);

That's just one of the defines that ecard.c uses from mach/hardare.h.
It happens to still compile, so it's getting included thru another
include. I see these options:

-Revert this change. RPC is not going to be built in a multi-platform
kernel anyway. Leaving it could affect how include paths get setup for
multi-platform builds.
-Move ecard.c into mach-rpc. It doesn't appear to be used by anything else.

I'll do the 1st option for now.

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help