Hi Sascha,

On Tuesday 28 June 2011, Sascha Hauer wrote:

+
+/* common register space */
+static void __iomem *pwm_base_common;
+#define REG_PWM_CTRL   0x0
+#define PWM_SFTRST     (1 << 31)
+#define PWM_CLKGATE    (1 << 30)
+#define PWM_ENABLE(p)  (1 << (p))
+

The driver looks pretty good overall, but the global pwm_base_common register
is rather ugly. I think this should really be passed down through resources
from  the platform device in one way or another.

	Arnd