Thread (5 messages) flat view 5 messages, 5 authors, 2011-06-13

[PATCH] fb.h: ARM uses __raw_{read/write}

From: Paul Mundt <hidden>
Date: 2011-06-13 04:00:36
Also in: linux-fbdev, lkml

On Fri, Jun 10, 2011 at 05:31:08PM -0700, H Hartley Sweeten wrote:
ARM provides __raw_{read/write}* functions for memory access. These
should be used instead of the default '(*(volatile' stuff to make sure the
memory accesses are typesafe (void __iomem *).

This also fixes a number of sparse warning like:

  warning: cast removes address space of expression

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Paul Mundt <redacted>
Cc: Russell King <redacted>
I'm not sure what semantics are desirable for ARM here, so I'll wait for
Russell to reply.

This wrapping will basically mean that the fb_read/write ops are using
__raw_xxx variants while the memset and memcpy wrappers will be using the
regular read/write[bwl] routines which contain __iormb() calls. Given
that ioread/write and friends all wrap in to the normal versions with the
barriers, I would suppose that this is the default behaviour that is
desired, as opposed to wrapping in to the __raw_xxx variants directly.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help