[PATCH] ARM: omap4: gpio: fix setting IRQWAKEN bits

Todd Poynor [off-list ref] writes:

On Mon, Jun 06, 2011 at 03:32:29PM -0700, Kevin Hilman wrote:

quoted

Colin Cross [off-list ref] writes:

quoted

On Sat, Jun 4, 2011 at 12:03 PM, Colin Cross [off-list ref] wrote:

quoted

Setting the IRQWAKEN bit was overwriting previous IRQWAKEN bits,
causing only the last bit set to take effect, resulting in lost
wakeups when the GPIO controller is in idle.

Replace direct writes to IRQWAKEN with writes to SETWKUENA and
CLEARWKUEN.

Signed-off-by: Colin Cross <redacted>

[...]

quoted

Todd pointed out that the OMAP4 TRM says not to use SETWKUENA and
CLEARWKUENA.  

In my GPIO cleanups, I was wondering why the set/clear registers were
not used here. Todd, can you give the TRM version & reference for this?
I didn't find anything after a quick scan/search.

http://focus.ti.com/general/docs/wtbu/wtbudocumentcenter.tsp?templateId=6123&navigationId=12037

OMAP4460 Multimedia Device Silicon Revision 1.0 Version E
February 2011?Revised May 2011

p. 5357 Table 25-68. GPIO_CLEARWKUPENA

"Caution: This register is kept for backward software compatibility. Use
GPIO_IRQWAKEN_0 and GPIO_IRQWAKEN_1 instead."

OK, I see it now.

Thanks,

Kevin