Thread (12 messages) 12 messages, 5 authors, 2011-06-01

[PATCH 2/3] clocksource: add DB8500 PRCMU Timer support

From: Linus Walleij <hidden>
Date: 2011-06-01 08:37:22
Also in: lkml

2011/6/1 Russell King - ARM Linux [off-list ref]:
On Tue, May 31, 2011 at 11:18:25PM +0200, Linus Walleij wrote:
quoted
Keeping it under include/linux is probably wise since we want drivers
OUT of the ARM tree, but I don't know if there is much consensus on that?
Header files private to a driver should be alongside the driver. ?Look
at drivers/net or drivers/scsi for plenty of examples.

Just because its a header file does not mean it must be in some directory
with 'include' in its path. ?The only reason to put it in include/linux
is if it contains stuff which needs to be shared outside of the driver
(eg, with arches).
I agree. Right now I have a creepy feeling that many drivers are just
putting headers in <mach/foo.h> out of habit, when plain "foo.h" in
working dir or <linux/subsystem/foo.h> is what is really apropriate.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help