Hi Sekhar,

Thanks for the review.

On Wed, May 18, 2011 at 9:18 AM, Nori, Sekhar [off-list ref] wrote:

[...]

quoted

? ? ? if (len) {
? ? ? ? ? ? ? len = min_t(unsigned, len, SRAM_SIZE);
- ? ? ? ? ? ? davinci_pv_pool = pv_pool_create((void *)SRAM_VIRT,
+ ? ? ? ? ? ? addr = ioremap(davinci_soc_info.sram_phys, len);
+ ? ? ? ? ? ? if (!addr)
+ ? ? ? ? ? ? ? ? ? ? return -EIO;

-ENOMEM here (for the next time you post). See Sergei's
mail on error codes below. Useful stuff.

https://patchwork.kernel.org/patch/47365/

Will do. Thanks for the useful reference also (and to Sergei for writing it).

Best Regards,
Ben Gardiner

---
Nanometrics Inc.
http://www.nanometrics.ca