Thread (1 message) 1 message, 1 author, 2011-05-16
DORMANTno replies

[PATCH 1/1] ARM: thumb: Fix thumb mode compilation problems.

From: Frank Hofmann <hidden>
Date: 2011-05-16 09:19:56

Message: 2
Date: Fri, 13 May 2011 12:58:58 -0700 (PDT)
From: vbendeb at google.com (Vadim Bendebury)
To: linux-arm-kernel at lists.infradead.org
Subject: [PATCH 1/1] ARM: thumb: Fix thumb mode compilation problems.
Message-ID: [ref]

ARM: thumb: Fix thumb mode compilation problems.

This change has not been tested in this tree (other than
verifying compilation/linking success in both Thumb2 and regular
modes).

It was however tested in a Chromium OS tree
(http://www.chromium.org/chromium-os). The latest fiq.c version
of the Chromium OS is the same as arm.linux.org.uk, so the patch
applies as is, headsmp.S is different, but the patch applies the
same.

Signed-off-by: Vadim Bendebury <redacted>
---
[ ... ]
quoted hunk
diff --git a/arch/arm/mach-tegra/headsmp.S b/arch/arm/mach-tegra/headsmp.S
index b5349b2..bcbfbab 100644
--- a/arch/arm/mach-tegra/headsmp.S
+++ b/arch/arm/mach-tegra/headsmp.S
@@ -48,7 +48,8 @@ ENTRY(v7_invalidate_l1)
ENDPROC(v7_invalidate_l1)

ENTRY(tegra_secondary_startup)
-	msr	cpsr_fsxc, #0xd3
+	mov     r0, #0xd3
+	msr     cpsr_fsxc, r0
        bl      v7_invalidate_l1
	mrc	p15, 0, r0, c0, c0, 5
        and	r0, r0, #15
Just a nit:
Hardcoded hex for CPSR contents ... can't this be made readable:

 	#include <asm/ptrace.h>
 	...
 	mov	r0, #(MODE_SVC | PSR_F_BIT | PSR_I_BIT)
 	...

Or are there very specifiy restrictions for headsmp.S that prevent the use 
of include files ?

FrankH.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help