[PATCH] [RFC] USB: fsl_udc_core: fix build-failure for ARM

Hi Russell,

On Fri, May 06, 2011 at 10:04:49AM +0100, Russell King - ARM Linux wrote:

On Fri, May 06, 2011 at 11:00:05AM +0200, Uwe Kleine-K?nig wrote:

quoted

I'm unsure about getting rid of the flush_dcache_range. If powerpc needs
a flush ARM probably does, too, no?
If so, what it the right thing to do? Implement flush_dcache_range for
ARM (just wrapping flush_dcache_page?)?

On ARM, we assume all new pages have dirty dcache, which allows us to
neatly end the ever-increasing quantity of drivers which need to be
patched to work on ARM.  PowerPC doesn't do this.

Unless I'm missing something the cache flushed here isn't necessarily
for a new page. (And even if the flush isn't needed here for ARM, not
having flush_dcache_range results in #ifdefs for each user of it. So a
definition would be nice, wouldn't it?)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |