[PATCH][RFC] Add mt9p031 sensor support.

Hi Javier,

On Wednesday 25 May 2011 11:41:42 javier Martin wrote:

Hi,
thank you for the review, I agree with you on all the suggested
changes except on this one:

On 25 May 2011 10:05, Laurent Pinchart wrote:

quoted

On Tuesday 24 May 2011 16:30:43 Javier Martin wrote:

quoted

This RFC includes a power management implementation that causes
the sensor to show images with horizontal artifacts (usually
monochrome lines that appear on the image randomly).

Signed-off-by: Javier Martin <redacted>

[snip]

quoted

diff --git a/drivers/media/video/mt9p031.c

b/drivers/media/video/mt9p031.c new file mode 100644
index 0000000..04d8812

--- /dev/null
+++ b/drivers/media/video/mt9p031.c

[snip]

quoted

+#define MT9P031_WINDOW_HEIGHT_MAX            1944
+#define MT9P031_WINDOW_WIDTH_MAX             2592
+#define MT9P031_WINDOW_HEIGHT_MIN            2
+#define MT9P031_WINDOW_WIDTH_MIN             18

Can you move those 4 constants right below MT9P031_WINDOW_HEIGHT and
MT9P031_WINDOW_WIDTH ? The max values are not correct, according to the
datasheet they should be 2005 and 2751.

In figure 4, it says active image size is 2592 x 1944
Why should I include active boundary and dark pixels?

Users might want to get the dark pixels for black level compensation purpose. 
As the chip allows for that, it should be supported. The default should of 
course be the active area of 2592 x 1944 pixels.

-- 
Regards,

Laurent Pinchart