Thread (18 messages) 18 messages, 5 authors, 2011-05-31

[PATCH 1/4] gpio: gpio-mxc: add gpio driver for Freescale MXC architecture

From: Shawn Guo <hidden>
Date: 2011-05-31 09:11:53
Also in: lkml

Hi Jamie,

On Tue, May 31, 2011 at 09:44:24AM +0100, Jamie Iles wrote:
Hi Shawn,

On Mon, May 30, 2011 at 10:52:16PM +0800, Shawn Guo wrote:
quoted
Add gpio-mxc driver by copying arch/arm/plat-mxc/gpio.c into
drivers/gpio with the following changes.

 * Use readl/writel to replace mach-specific accessors
   __raw_readl/__raw_writel

 * Migrate to platform driver by adding .probe function

 * Add a list to save all mx2 ports references, so that
   mx2_gpio_irq_handler can walk through all interrupt status
   registers

Signed-off-by: Shawn Guo <redacted>
---
Could you use the stuff in drivers/gpio/basic_mmio_gpio.c for 
implementing the gpio_chip?  I had a go a little while ago [1] but since 
then we've made it possible to embed the bgpio_chip in your own 
structure which may be cleaner.

Jamie

1. http://permalink.gmane.org/gmane.linux.ports.arm.kernel/113139
--
I would like to keep this series as simple as it is, straight moving
plat-mxc/gpio into drivers/gpio, and then start looking at the
possible consolidation, like generic_irq_chip and basic_mmio_gpio you
offered here.  Thanks for the patch.  I will start with it shortly. 

-- 
Regards,
Shawn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help