Thread (19 messages) 19 messages, 3 authors, 2011-06-01

IrDA driver fails on PXA255

From: Russell King - ARM Linux <hidden>
Date: 2011-05-29 21:58:22
Also in: lkml

On Sun, May 29, 2011 at 02:19:40PM -0700, David Rientjes wrote:
On Sun, 29 May 2011, Russell King - ARM Linux wrote:
quoted
quoted
arm, pxa2xx: enable DMA support for pxa2xx IRDA interface

The pxa2xx-ir driver allocates with GFP_DMA, so it must always have 
ZONE_DMA.
Wrong way.  If there's no restrictions, drivers shouldn't be using
GFP_DMA.  For the majority of SoCs, that's the case.
That's great, but before you can actually determine what requires DMA for 
this driver and what doesn't, we need something for this merge window (and 
backported to -stable) so that users aren't forced to go through and 
enable CONFIG_ZONE_DMA on their own .config.

Is there a downside to enabling CONFIG_ZONE_DMA for all configs that 
compile this driver until a better solution can be found?
We might as well enable CONFIG_ZONE_DMA for everything if that's what
you're proposing, because it's not just this driver which will be affected.
And as soon as we do that, we completely lose the warnings that stuff
needs fixing.

This is not the way to sort this problem out.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help