[PATCH V4 1/5] dmaengine/dw_dmac: don't call callback routine in case dmaengine_terminate_all() is called
From: Koul, Vinod <hidden>
Date: 2011-05-09 05:35:21
Also in:
lkml
On Thu, 2011-05-05 at 17:30 +0530, Viresh Kumar wrote:
quoted hunk ↗ jump to hunk
If dmaengine_terminate_all() is called for dma channel, then it doesn't make much sense to call registered callback routine. While in case of success or failure it must be called. Signed-off-by: Viresh Kumar <redacted> --- drivers/dma/dw_dmac.c | 31 ++++++++++++++++--------------- 1 files changed, 16 insertions(+), 15 deletions(-)diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c index 1bd4803..d28cd84 100644 --- a/drivers/dma/dw_dmac.c +++ b/drivers/dma/dw_dmac.c@@ -195,18 +195,21 @@ static void dwc_dostart(struct dw_dma_chan *dwc, struct dw_desc *first) /*----------------------------------------------------------------------*/
- /*
- * The API requires that no submissions are done from a
- * callback, so we don't need to drop the lock here
- */
- if (callback)
- callback(param);
+ if (callback_required) {
+ if (callback)
+ callback(param);
+ }How about changing this to: if (callback_required && callback) callback(param) This will make it look cleaner ... -- ~Vinod