Thread (18 messages) 18 messages, 5 authors, 2011-09-19

[PATCH] ARM: BUG() dies silently

From: sjg@chromium.org (Simon Glass)
Date: 2011-04-05 16:43:27
Also in: lkml

On Tue, Apr 5, 2011 at 9:02 AM, Ramirez Luna, Omar [off-list ref] wrote:
Hi,

On Tue, Apr 5, 2011 at 12:46 AM, Simon Glass [off-list ref] wrote:
quoted
On Mon, Apr 4, 2011 at 7:29 PM, Ramirez Luna, Omar [off-list ref] wrote:
...
quoted hunk ↗ jump to hunk
quoted
quoted
OTOH, is not like "Use generic BUG() handler" gives the choice of
removing GENERIC_BUG given that it is not prompted in menuconfig and
auto selected, if this is the intention is there any reason to keep
the #else part of /* not CONFIG_GENERIC_BUG */? there is no way we can
use it with this patch, right?
Well, er, the intention is that you use the patch. I kept the old code
around since people can then simply change the Kconfig option and be
back where they were, as indeed you have. I would be happy to remove
the old behavior, but I was concerned about a possible roasting in
this forum. Changing long-established behavior is sometimes tricky.
Yes, but you can't change the Kconfig because it is not prompted with
your patch, if that was the intention then an option to de/select
GENERIC_BUG or not is needed:

arch/arm/Kconfig
@@ -204,6 +204,10 @@ config MMU
? ? ? ? ?Select if you want MMU-based virtualised addressing space
? ? ? ? ?support by paged memory management. If unsure, say 'Y'.

+config GENERIC_BUG
+ ? ? ? bool "Generic BUG"
+ ? ? ? default y
+ ? ? ? depends on BUG
Yes that's right, it is a manual edit. But if there are no objections
I will create a patch to remove this and replace the old bug
infrastructure entirely. - Simon
Regards,

Omar
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help