Thread (17 messages) flat view 17 messages, 5 authors, 2011-03-07
STALE5640d REVIEWED: 1 (0M)

Revision v1 of 3 in this series; 1 review trailer.

Revisions (3)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 current

[PATCH 2/3] ARM: tegra: harmony: register i2c devices

From: Stephen Warren <hidden>
Date: 2011-03-07 17:29:26
Also in: linux-tegra

Olof Johansson wrote at Monday, March 07, 2011 1:27 AM:
Register the base i2c busses on harmony. Devices coming at a later date,
but this allows for hand-probing of some of them at least.

Signed-off-by: Olof Johansson <redacted>
This looks OK to me.

Addressing Sergei's comments:
quoted
+static struct tegra_i2c_platform_data harmony_dvc_platform_data = {
+	.bus_clk_rate   = 400000,
+};
    Why not share the paltform data between devices if it's the same anyway?
Right now, the upstream tegra_i2c_platform_data has fewer fields than some
changes that I imagine are coming down the pipe from ChromeOS. i.e. the
content of those 3 platform data will probably be different in the future.
For this reason, it seems reasonable to keep them separate from the start.
But, unifying them for now and separating in a future patch would be fine by
me too.

Acked-by: Stephen Warren <redacted>

-- 
nvpublic
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help