Thread (6 messages) flat view 6 messages, 3 authors, 2011-03-15
STALE5641d

[PATCH] ARM: mxs/tx28: fix up LCD pads

From: Shawn Guo <hidden>
Date: 2011-03-05 16:27:20
Subsystem: arm port, the rest · Maintainers: Russell King, Linus Torvalds

* In any case, LCD only needs one group of VSYNC, HSYNC, and DOTCLK.
  So remove the redundant and useless one.
* LCD_ENABLE pad should not work as a GPIO for LCD, and there must be
  one pad for ENABLE function.

Signed-off-by: Shawn Guo <redacted>
---
Hi Lothar, Uwe,

I do not have the schematics of TX28 board, and I'm guessing the fix.
So it really needs your comments here.

Regards,
Shawn

 arch/arm/mach-mxs/mach-tx28.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-mxs/mach-tx28.c b/arch/arm/mach-mxs/mach-tx28.c
index b65e371..16a0059 100644
--- a/arch/arm/mach-mxs/mach-tx28.c
+++ b/arch/arm/mach-mxs/mach-tx28.c
@@ -61,11 +61,7 @@ static const iomux_cfg_t tx28_stk5v3_pads[] __initconst = {
 	MX28_PAD_LCD_RD_E__LCD_VSYNC | LCD_MODE,
 	MX28_PAD_LCD_WR_RWN__LCD_HSYNC | LCD_MODE,
 	MX28_PAD_LCD_RS__LCD_DOTCLK | LCD_MODE,
-	MX28_PAD_LCD_CS__LCD_CS | LCD_MODE,
-	MX28_PAD_LCD_VSYNC__LCD_VSYNC | LCD_MODE,
-	MX28_PAD_LCD_HSYNC__LCD_HSYNC | LCD_MODE,
-	MX28_PAD_LCD_DOTCLK__LCD_DOTCLK | LCD_MODE,
-	MX28_PAD_LCD_ENABLE__GPIO_1_31 | LCD_MODE,
+	MX28_PAD_LCD_CS__LCD_ENABLE | LCD_MODE,
 	MX28_PAD_LCD_RESET__GPIO_3_30 | LCD_MODE,
 	MX28_PAD_PWM0__PWM_0 | LCD_MODE,
 
-- 
1.7.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help